Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge walk failed #4684

Open
xuruiray opened this issue Apr 11, 2024 · 0 comments
Open

edge walk failed #4684

xuruiray opened this issue Apr 11, 2024 · 0 comments
Labels

Comments

@xuruiray
Copy link

xuruiray commented Apr 11, 2024

uint32_t level = node.level();
uint32_t start_de = followed_edges[correlated_index][level].first;
// Iterate through directed edges from this node
const NodeInfo* nodeinfo = tile->node(node);
GraphId edge_id(node.tileid(), level, nodeinfo->edge_index());
const DirectedEdge* de = tile->directededge(nodeinfo->edge_index());
for (uint32_t i = start_de; i < nodeinfo->edge_count(); i++, de++, ++edge_id) {
// Mark the directed edge as already followed
followed_edges[correlated_index][level].first = i;
// Skip shortcuts and transit connection edges

why do we need followed_edges ? I feel like this is a useless cache, use start_de will skip some edge from the current node

image

There's a scenario.
when we get the wrong path and try to step back, it is the same correlated_index but not the same node (because there are two very similar edges)
if use start_de from followed_edges will skip some edge

@nilsnolde nilsnolde added the bug label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants