Yeah, not having access to the config in costing makes quite a few things very ugly/hard.. @kevinkreiser had the idea to make the config a singleton which gets created first thing on startup of any process and is then easily accessible to every file. Then we remove all the code passing down the config to every small function way downstream.

Is that smth you'd be interested in as well? The singleton itself isn't much work I think..

Thanks for the quick reply. The suggestion sounds useful and I could not think about any drawbacks to this singleton, it is just the bad rep that it gets and the many little rewrites of source and tests that makes me think about other ways to achieve the solution.

Maybe it would be enough if we find a way to make the config pt available in the dynamic cost class?

if we find a way to make the config pt available in the dynamic cost class

I looked into that before, I don't think we'd like that as a project (correct me @kevinkreiser). We should really do the work for the singleton (which is totally fine IMO, if used wisely), instead of further digging that hole. 95% of the changes are mechanical I think.

yeah passing the config into every place we need costing is a refactor nightmare. we need to do the global config singleton idea and then remove config passing from vast swathes from the code base. i forget if i have an issue for this but its definitely the way to go

its this one, just updated: #1158

Okay this will be something that we'll work on then