Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: revert #863 #1657

Closed
IceCodeNew opened this issue May 12, 2023 · 4 comments · Fixed by #1705
Closed

TODO: revert #863 #1657

IceCodeNew opened this issue May 12, 2023 · 4 comments · Fixed by #1705
Assignees

Comments

@IceCodeNew
Copy link
Collaborator

There was a discussion about it, and we are planning to revert the PR #863
This issue is for notification and tracking the progress.

For anyone who may concern about the discussion, please refer to the following:

@IceCodeNew IceCodeNew self-assigned this May 12, 2023
@IceCodeNew IceCodeNew pinned this issue May 12, 2023
@rootmelo92118
Copy link
Collaborator

I have no objection to revert the PR, after all, there is no guarantee that there are any remaining problems. But at the same time, I don't think the original PR is completely worthless. I have saved domains that will be removed. I will check these domain names again, and the domain names after the check will be re-added to category-porn.

@rootmelo92118
Copy link
Collaborator

rootmelo92118 commented May 12, 2023

Wait a minute. I used OpenDNS to resolve which domains are belonging to pornographic websites. (also remove the domain which is expired). I got 908 domains, and the total domains have 994. It means most of the domain will be re-added. Are you sure you want to revert it?
outputdomain.txt

@IceCodeNew
Copy link
Collaborator Author

IceCodeNew commented May 12, 2023

Wait a minute. I used OpenDNS to resolve which domains are belonging to pornographic websites. (also remove the domain which is expired). I got 908 domains, and the total domains have 994. It means most of the domain will be re-added. Are you sure you want to revert it? outputdomain.txt

Yes, I am going to revert that PR, no matter what. The nature of the problem is copying the contents of a third-party source, which brings us to the problem of copyleft, sync & quality.
You may spot the miscategorized domains based on OpenDNS's labeling or something, but even if it is enough for salvaging the qualified parts, there are still problems that we can not solve.
After all, salvaging pornographic sited from a list of domains that are blocked in Korea is not a good idea.

rootmelo92118 added a commit that referenced this issue Jun 8, 2023
@Loyalsoldier
Copy link
Collaborator

Any progress?

rootmelo92118 added a commit that referenced this issue Dec 31, 2023
Fix #1657

It has no mistake of method to remove the domain which are submitted in #863. This PR will be merged. Welcome to discuss if you have any opinion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants