Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run flake8 #11

Open
bcipolli opened this issue Dec 31, 2015 · 6 comments
Open

Run flake8 #11

bcipolli opened this issue Dec 31, 2015 · 6 comments

Comments

@bcipolli
Copy link
Contributor

Great to have a template that follows PEP8 and passes pyflakes, even if most projects themselves choose not to follow the cleanliness of such a sparkling template :)

@jesford
Copy link

jesford commented Feb 11, 2016

flake8 is awesome!

However, I was not able to run it using the command provided in the README:

flake8 --ignore N802,N806 `find . -name *.py | grep -v setup.py | grep -v /doc/`

and also not when removing the (unintentional?) extra backticks:

flake8 --ignore N802,N806 find . -name *.py | grep -v setup.py | grep -v /doc/

It gives me this error:

Usage: flake8 [options] input ...

flake8: error: no such option: -n

But it runs fine if I just do this:

flake8 --ignore N802,N806 *.py | grep -v setup.py | grep -v /doc/

Not sure if its a typo in the README (I'm happy to submit a PR if so) or if its just me...

Thanks for this resource @arokem! Super helpful.

@arokem
Copy link
Contributor

arokem commented Feb 11, 2016

Just a guess here: should that be a -- before the name (two dashes
instead of one)?

On Wed, Feb 10, 2016 at 7:06 PM, Jes Ford notifications@github.com wrote:

flake8 is awesome!

However, I was not able to run it using the command provided in the README:

flake8 --ignore N802,N806 find . -name *.py | grep -v setup.py | grep -v /doc/

and also not when removing the (unintentional?) extra backticks:

flake8 --ignore N802,N806 find . -name *.py | grep -v setup.py | grep -v /doc/

It gives me this error:

Usage: flake8 [options] input ...

flake8: error: no such option: -n

But it runs fine if I just do this:

flake8 --ignore N802,N806 *.py | grep -v setup.py | grep -v /doc/

Not sure if its a typo in the README (I'm happy to submit a PR if so) or
if its just me...

Thanks for this resource @arokem https://github.com/arokem! Super
helpful.


Reply to this email directly or view it on GitHub
#11 (comment).

@jesford
Copy link

jesford commented Feb 11, 2016

No, that gives me the same error. Does it work for you?

@arokem
Copy link
Contributor

arokem commented Feb 11, 2016

Sorry - was really just guessing.

This does work for me (but might not work inside the Travis setup -- I
think that's what the README refers to?)

flake8 --ignore N802,N806 shablona/*.py

(issued from the top level repo directory).

On Wed, Feb 10, 2016 at 7:14 PM, Jes Ford notifications@github.com wrote:

No, that gives me the same error. Does it work for you?


Reply to this email directly or view it on GitHub
#11 (comment).

@rbiswas4
Copy link

Hi Jes,

Escaping the * might work:

find . -name _.py should probably be
find . -name _.py

The backticks are meant to run the find command and locate the *.py within
directories and then run flake 8 on that list. So, I think you could simply
run the flake8 command on an explicit file list to see if it is the flake8
command that is a problem or building the list of files.

Thanks,
Rahul

On Wed, Feb 10, 2016 at 7:22 PM, Ariel Rokem notifications@github.com
wrote:

Sorry - was really just guessing.

This does work for me (but might not work inside the Travis setup -- I
think that's what the README refers to?)

flake8 --ignore N802,N806 shablona/*.py

(issued from the top level repo directory).

On Wed, Feb 10, 2016 at 7:14 PM, Jes Ford notifications@github.com
wrote:

No, that gives me the same error. Does it work for you?


Reply to this email directly or view it on GitHub
<#11 (comment)
.


Reply to this email directly or view it on GitHub
#11 (comment).

@jesford
Copy link

jesford commented Feb 11, 2016

Thanks @rbiswas4 that works perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants