Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build conda package #92

Open
uwefladrich opened this issue Nov 3, 2022 · 6 comments
Open

Build conda package #92

uwefladrich opened this issue Nov 3, 2022 · 6 comments
Assignees
Labels
ci Changes to our CI configuration files and scripts feature New feature or request

Comments

@uwefladrich
Copy link
Owner

Since the rest of the ScriptEngine world is already on conda-forge (scriptengine and scriptengine-tasks-hpc) and since scriptengine-tasks-ecearth needs a conda environment anyway to install dependencies, we should provide a conda package on conda-forge.

@uwefladrich
Copy link
Owner Author

Pinging @zklaus, because we may need the expertise:

The easiest (naive?) way would be to follow the same approach as for the other SE packages: Build and publish a PyPI package in the CI actions and then let conda-forge feedstock repository pull and build a conda package. Maybe that makes sense, but it also feels a bit like beginning at the wrong end. After all, the PyPI package doesn't easily install outside a conda package anyway, so why would we need it in the first place?

@uwefladrich uwefladrich self-assigned this Nov 3, 2022
@uwefladrich uwefladrich added feature New feature or request ci Changes to our CI configuration files and scripts labels Nov 3, 2022
@zklaus
Copy link

zklaus commented Nov 3, 2022

The way I see it, the Pypi release is the actual release, i.e. the product. It should always be installable easily, but with the caveat that it does not take care of the dependencies, particularly in the case of the source distribution. As such, I think doing the (source) release on Pypi is unquestionably the first step.

@uwefladrich
Copy link
Owner Author

Okay, thanks! So that means that, since we already have the ci pipeline for publishing to PyPI, we can proceed along the lines of scriptengine and scriptengine-tasks-hpc. I will try to set up the PR to conda-forge/staged-recipes. I may come back for help 😁

@uwefladrich
Copy link
Owner Author

@valentinaschueller
Copy link
Collaborator

This is done!
Do you also want to update the documentation accordingly as part of this issue or should we create a new issue for that?

@uwefladrich
Copy link
Owner Author

I have added #96. Should not be too complicated, but I am not sure how quick I manage to do it. So whoever of us is first makes a suggestion, would that be okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to our CI configuration files and scripts feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants