Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package and modules #31

Open
uwefladrich opened this issue Mar 19, 2021 · 1 comment
Open

Rename package and modules #31

uwefladrich opened this issue Mar 19, 2021 · 1 comment
Assignees

Comments

@uwefladrich
Copy link
Owner

PEP8 says about module names:

Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged.

which seems to be translated into:

  • Package names should have dashes not underscores.
  • Module names must not have dashes and can have underscores.

Hence, the proposal is to rename

  • the package to scriptengine-ece
  • the module to scriptengine_ece

This is also related to uwefladrich/scriptengine#20, which drops the need for implementing SE tasks as namespace packages.

@uwefladrich uwefladrich self-assigned this Mar 19, 2021
@uwefladrich
Copy link
Owner Author

I have made corresponding changes to the scriptengine-hpc package, se uwefladrich/scriptengine-tasks-hpc#3 and the related commit.

valentinaschueller pushed a commit to valentinaschueller/scriptengine-tasks-ecearth that referenced this issue Oct 31, 2021
* see: uwefladrich#31
* renamed in most places, only the URLs have the old names
valentinaschueller pushed a commit to valentinaschueller/scriptengine-tasks-ecearth that referenced this issue Nov 2, 2021
* see: uwefladrich#31
* renamed in most places, only the URLs have the old names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant