Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question Regarding User Stream Listener #26

Open
abhishekShukla opened this issue Mar 12, 2014 · 0 comments
Open

Question Regarding User Stream Listener #26

abhishekShukla opened this issue Mar 12, 2014 · 0 comments

Comments

@abhishekShukla
Copy link

Hi,

I was going through the code.

I have questions regarding the code in this file:

src/main/scala/tshrdlu/util/bridge.scala

  1. I understand that "def onStatus(status: Status) = actor ! status" is handled by the "Bot" actor.

Events like below are handled by which actor?

def onDeletionNotice(notice: StatusDeletionNotice) = actor ! notice
def onStallWarning(warning: StallWarning) = actor ! warning

  1. You have case classes defined for few other events. Instead of that could you not have just worked if you had left the implementations empty?

For example:

Instead of

def onTrackLimitationNotice(int: Int) = actor ! TrackLimitationNotice(int)

This would have worked fine too.
def onTrackLimitationNotice(int: Int) { /* Purposefully left Empty */ }

Is there something that I am missing?
Good Practice, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant