Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the test_network_limit_time* tests #546

Open
apolukhin opened this issue Apr 27, 2024 · 0 comments
Open

Fix the test_network_limit_time* tests #546

apolukhin opened this issue Apr 27, 2024 · 0 comments
Labels
big A big feature help wanted We would appreciate PR

Comments

@apolukhin
Copy link
Member

apolukhin commented Apr 27, 2024

At the moment those tests are disabled as flacky

@pytest.mark.skip(reason='flacky')
async def test_network_limit_time_sends(service_client, gate):
gate.to_server_limit_time(CONNECTION_TIME_LIMIT, CONNECTION_LIMIT_JITTER)
logger.debug('Starting "test_network_limit_time_sends" check for 500')
got_error = False
for _ in range(FAILURE_RETRIES):
response = await service_client.get(SELECT_SMALL_TIMEOUT_URL)
if response.status != 200:
got_error = True
break
logger.debug('End of "test_network_limit_time_sends" check for 500')
assert got_error, 'Previous steps unexpectedly finished with success'
await _check_that_restores(service_client, gate)
@pytest.mark.skip(reason='flacky')
async def test_network_limit_time_recv(service_client, gate):
gate.to_client_limit_time(CONNECTION_TIME_LIMIT, CONNECTION_LIMIT_JITTER)
logger.debug('Starting "test_network_limit_time_recv" check for 500')
got_error = False
for _ in range(FAILURE_RETRIES):
response = await service_client.get(SELECT_SMALL_TIMEOUT_URL)
if response.status != 200:
got_error = True
break
logger.debug('End of "test_network_limit_time_recv" check for 500')
assert got_error, 'Previous steps unexpectedly finished with success'
await _check_that_restores(service_client, gate)
@pytest.mark.skip(reason='flacky')
async def test_network_limit_time(service_client, gate):
gate.to_server_limit_time(CONNECTION_TIME_LIMIT, CONNECTION_LIMIT_JITTER)
gate.to_client_limit_time(CONNECTION_TIME_LIMIT, CONNECTION_LIMIT_JITTER)
logger.debug('Starting "test_network_limit_time" check for 500')
got_error = False
for _ in range(FAILURE_RETRIES):
response = await service_client.get(SELECT_SMALL_TIMEOUT_URL)
if response.status != 200:
got_error = True
break
logger.debug('End of "test_network_limit_time" check for 500')
assert got_error, 'Previous steps unexpectedly finished with success'
await _check_that_restores(service_client, gate)

Restore the tests and make them reliable

Internal ticket: 7988

@apolukhin apolukhin added help wanted We would appreciate PR big A big feature labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big A big feature help wanted We would appreciate PR
Projects
None yet
Development

No branches or pull requests

1 participant