Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch all the databases to TestsuiteSupport::GetIncreasedTimeout() in tests #544

Open
apolukhin opened this issue Apr 27, 2024 · 0 comments
Open

Switch all the databases to TestsuiteSupport::GetIncreasedTimeout() in tests #544

apolukhin opened this issue Apr 27, 2024 · 0 comments
Labels
big A big feature help wanted We would appreciate PR

Comments

@apolukhin
Copy link
Member

apolukhin commented Apr 27, 2024 •
edited

Rather than using DB specific timeouts

userver/core/include/userver/testsuite/testsuite_support.hpp

Lines 67 to 68 in 4348f91

const testsuite::PostgresControl& GetPostgresControl();
const testsuite::RedisControl& GetRedisControl();

we should switch to a generic one

userver/core/include/userver/testsuite/testsuite_support.hpp

Line 75 in 4348f91

std::chrono::milliseconds GetIncreasedTimeout() const noexcept;

an use it everywhere, including Mongo

Internal ticket: 8373
@apolukhin apolukhin added good first issue Good small issue for newcomers help wanted We would appreciate PR big A big feature and removed good first issue Good small issue for newcomers labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
big A big feature help wanted We would appreciate PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apolukhin