Consider using LSP Diagnostic Pull?

[karlhorky]

Hi @usernamehw ! 👋 Hope you are well.

As a follow-up to #55 and #57, do you think that the new LSP Diagnostic Pull proposal (from this original issue) would be a good fit for Error Lens, once it's available? This would make getting the diagnostics more efficient, and allow for a pull-based mode to better implement onSave.

There was an announcement in the release notes for VS Code 1.54: https://code.visualstudio.com/updates/v1_54#_language-server-protocol

Language Server Protocol

A first proposal of a diagnostic pull model got implemented for the upcoming 3.17 release. The proposal is available in the next versions of the VS Code LSP libraries.

[usernamehw]

Alright, subscribed to closing event of microsoft/language-server-protocol#737 . It's not finalized yet, yes?

[karlhorky]

Yeah I think it's been implemented by @dbaeumer, but only as a proposal: microsoft/vscode#117042

I guess it's going to come in the 3.17 LSP release? Not sure what that means regarding which VS Code version it will land in though...

[karlhorky]

Ah, there's a draft version of the diagnostic pull model specification now open for feedback:

https://github.com/microsoft/vscode-languageserver-node/blob/main/protocol/src/common/proposed.diagnostics.md

[karlhorky]

I guess this "got published", apparently? microsoft/vscode#112501 (comment)

I asked over here about documentation on how to use it: microsoft/language-server-protocol#737 (comment)

[karlhorky]

Alright, pull-based diagnostics were shipped in v3.17 of the language server protocol! 🙌

Would be so great to have this trickle down to extensions to make them more performant 👍