Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorLens.margin has no effect #192

Open
spikespaz opened this issue Nov 6, 2023 · 6 comments
Open

errorLens.margin has no effect #192

spikespaz opened this issue Nov 6, 2023 · 6 comments

Comments

@spikespaz
Copy link

image

  "editor.fontFamily": "'Material Design Icons', 'JetBrainsMono Nerd Font'",

  "errorLens.delayMode": "debounce",
  "errorLens.enabledDiagnosticLevels": [
    "error",
    "warning"
  ],
  "errorLens.enabledInMergeConflict": false,
  "errorLens.margin": "4ch",
  "errorLens.onSaveTimeout": 200,
  "errorLens.removeLinebreaks": false,

VS Code

Version: 1.83.1
Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
Date: 2023-10-10T23:45:31.402Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Linux x64 6.5.9

Error Lens v3.15.0

@usernamehw
Copy link
Owner

Are you using errorLens.alignMessage?

@spikespaz
Copy link
Author

spikespaz commented Nov 6, 2023

Are you using errorLens.alignMessage?

No, the settings I have shown are all that I have used.

@usernamehw
Copy link
Owner

usernamehw commented Nov 6, 2023

I don't know then. It doesn't reproduce with these settings.

Can you narrow it down to 1 setting or a combination of settings (minimal repro steps)?


Does it work with other units?:

"errorLens.margin": "40px",
// or
"errorLens.margin": "4em",

@spikespaz
Copy link
Author

I apologize for removing the issue template. That was disrespectful, and I missed some of the minimum requirements for a useful issue.


It looks like ch is the only unit that doesn't work. This happens regardless of other settings being present. Margin is the first setting I changed for Error Lens quite some time ago. I discovered it didn't work, so other settings were irrelevant.

@usernamehw
Copy link
Owner

Maybe it's the "editor.fontFamily" setting? Material Design Icons doesn't make sense to use as an editor font...

@spikespaz
Copy link
Author

It does make sense if you use VS Code to edit your waybar config or your terminal prompt.

I believe that the problem only happens when that font is first in fallback. Will check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants