Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Tests for Webhooks #640

Open
diego-escobedo opened this issue Mar 7, 2023 · 2 comments
Open

Write Tests for Webhooks #640

diego-escobedo opened this issue Mar 7, 2023 · 2 comments

Comments

@diego-escobedo
Copy link
Collaborator

Currently working on #639, which adds tests for invoice.paid and invoice.past_due. Necessary to write some more tests for the other ones we have so far using the same patching scheme.
@djanda97
Copy link
Contributor

Hi @diego-escobedo, I would be interested in adding more webhook tests. After taking a look at backend/metering_billing/tests/test_subscription.py, I can't find the TestInvoiceWebhooks class that was added in #639. It appears to have been deleted/overwritten in #615. Is the webhook functionality covered by another test?

@diego-escobedo
Copy link
Collaborator Author

Hey David! Unfortunate side effect of such a big merge. Currently I don't believe there's any tests covering that functionality so we would have to restore those + add new ones

@djanda97 djanda97 mentioned this issue Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@djanda97 @diego-escobedo and others