Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errata-Specific Test Cases #59

Open
kolektiv opened this issue Jul 29, 2023 · 0 comments
Open

Errata-Specific Test Cases #59

kolektiv opened this issue Jul 29, 2023 · 0 comments

Comments

@kolektiv
Copy link

kolektiv commented Jul 29, 2023

I can see from the closed issues and the RFC errata history that the "'" character is allowed in literals now. However, I didn't realise that initially, and was quite confused as to why the second test case in spec-examples.json included what I thought to be an invalid literal. Obviously I've tracked that down, but would it be worth making this more obvious?

One way to do so might be to remove that test from the spec-examples.json file (it doesn't actually appear in the RFC itself) and creating a small new test case file (something like spec-errata-examples.json perhaps) which would include any cases which reflect changes to the spec? That would potentially make it clearer for example that the spec has changed, and also point people in the direction of checking errata during implementation (yes, I know I should anyway, but it's not always glaringly obvious).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant