Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests with $ sign are missing #55

Open
wertzui opened this issue Jun 7, 2022 · 1 comment
Open

Tests with $ sign are missing #55

wertzui opened this issue Jun 7, 2022 · 1 comment

Comments

@wertzui
Copy link

wertzui commented Jun 7, 2022

The spec states

The expression syntax specifically excludes use of the dollar ("$")
and parentheses ["(" and ")"] characters so that they remain
available for use outside the scope of this specification.

I've come across an implementation at https://github.com/tavis-software/Tavis.UriTemplates that is using this test suite and does throw when it encounter a parameter with a $ sign, like this one that could be an OData endpoint:

https://example.com/{?$filter,$orderby,$top,$skip}
@sigmavirus24
Copy link

Do they run the negative tests?

[ "{$var}", false ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants