Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Possible StaticModel Bug #2860

Open
SirNate0 opened this issue Jan 4, 2022 · 1 comment
Open

Possible StaticModel Bug #2860

SirNate0 opened this issue Jan 4, 2022 · 1 comment
Labels

Comments

@SirNate0
Copy link
Contributor

SirNate0 commented Jan 4, 2022

I came across this code today while trying to determine how I should set up the worldTransform_ for the Drawable SourceBatch, and I thought it may have been a bug. A quick search in my IDE for C++ usages (which doesn't always find all of them) gave no other cases where the worldTransform_ for the batch is set to a nullptr other than this case when the StaticModel has a model set without a node. Everywhere else seems to set it to a value or &Matrix3x4::IDENTITY. Not sure if it's actually a bug, but I thought it might be since it seems to say that there is 1 worldTransform matrix (the default) but the array is a nullptr.

https://github.com/urho3d/Urho3D/blob/4075d36fe75bf834410c80c9207d6055e8b82761/Source/Urho3D/Graphics/StaticModel.cpp#L255-L261

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Marking this stale since there has been no activity for 30 days.
It will be closed if there is no activity for another 15 days.

@github-actions github-actions bot added the stale label Feb 4, 2022
@1vanK 1vanK added backlog and removed stale labels Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants