Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout cycle detected when resizing a view that has a NavigationView and TabBar #1131

Closed
ArchieCoder opened this issue May 10, 2024 · 5 comments · Fixed by #1138
Closed

Layout cycle detected when resizing a view that has a NavigationView and TabBar #1131

ArchieCoder opened this issue May 10, 2024 · 5 comments · Fixed by #1138
Assignees
Labels
control/auto-layout kind/bug Something isn't working

Comments

@ArchieCoder
Copy link

Current behavior

When the view gets smaller, an exception is fired and the app crashes

Expected behavior

No crash

How to reproduce it (as minimally and precisely as possible)

UnoTabApp.zip

or

1- Create a new project with the default option (Fluent and Materal, it's irrevelant).
2- Copy paste the page content of the HomePage from Commerce app. The goal is to test the NavigationView + Tab bar. Fix the namespaces.
3- Deploy and resize the app.

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

5.2.121

Affected platforms

Windows (WinAppSDK)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@ArchieCoder ArchieCoder added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels May 10, 2024
@ArchieCoder
Copy link
Author

Interesting, I tried to resize super fast and I was able to see the TabBar for 1 second before the app crashes.

@agneszitte
Copy link
Contributor

agneszitte commented May 10, 2024

fyi @kazo0, @Xiaoy312 we will need to quickly check what is happening. Maybe a resource is not found and that is causing this exception or something else

@ArchieCoder
Copy link
Author

Good news, the utu:AutoLayout is the cause the crash.

If you replace utu:AutoLayout with StackPanel, there is no crash however, the rendering is not what to expect.

At least, it can help investigate the issue.

@agneszitte
Copy link
Contributor

agneszitte commented May 10, 2024

Good news, the utu:AutoLayout is the cause the crash.

If you replace utu:AutoLayout with StackPanel, there is no crash however, the rendering is not what to expect.

At least, it can help investigate the issue.

Yes @kazo0 also noticed the same thing with his tests. We will continue to investigate.

Thank you for the feedback @ArchieCoder, appreciated.

@kazo0 kazo0 transferred this issue from unoplatform/uno May 13, 2024
@carldebilly carldebilly self-assigned this May 13, 2024
@kazo0 kazo0 added control/auto-layout and removed triage/untriaged Indicates an issue requires triaging or verification. labels May 13, 2024
carldebilly added a commit that referenced this issue May 14, 2024
@carldebilly
Copy link
Member

Cause of the bug has been found and this PR should fix it: #1138

Thanks @ArchieCoder for reporting this bug!

cc @kazo0

mergify bot pushed a commit that referenced this issue May 17, 2024
…ould go into an invalidation loop.

fixes #1131

(cherry picked from commit 8a877e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control/auto-layout kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants