Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MvvmCross Support #1250

Open
4 tasks done
jeromelaban opened this issue Jul 17, 2019 · 3 comments
Open
4 tasks done

MvvmCross Support #1250

jeromelaban opened this issue Jul 17, 2019 · 3 comments
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/third-party 3️⃣ Categorizes an issue or PR as relevant to 3rd party libraries

Comments

@jeromelaban
Copy link
Member

jeromelaban commented Jul 17, 2019

What would you like to be added:

MVVM Cross support.

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • Windows

Anything else we need to know?

Ongoing work is available here: https://github.com/nickrandolph/MvvmCross/tree/feature/uno3support
PR to mvvmcross: MvvmCross/MvvmCross#3898

@jeromelaban jeromelaban added the kind/enhancement New feature or request label Jul 17, 2019
@davidjohnoliver
Copy link
Contributor

For now, using MvvmCross with Uno on WebAssembly requires setting the following somewhere in app code (eg from App.xaml.cs constructor):

#if __WASM__
            Windows.UI.Core.CoreDispatcher.HasThreadAccessOverride = true;
#endif

Otherwise MvvmCross' ExecuteOnMainThreadAsync() method will deadlock (because Uno's CoreDispatcher.HasThreadAccess will always return false).

This is a temporary requirement, until WASM threading is supported on all browsers and by Mono (mono/mono#12453).

@MartinZikmund MartinZikmund changed the title MVVM Cross Support MvvmCross Support Sep 3, 2020
@nickrandolph
Copy link
Contributor

@davidjohnoliver I've just updated the Uno bits in mvvmcross to Uno v3. I assume that the threading workaround is still required? Or should MvvmCross work without the HasThreadAccessOverride being set to true?

@davidjohnoliver
Copy link
Contributor

Yes the workaround is still required. There's been some progress on threading support on Mono, but it's still at an experimental state and it's not yet enabled in Uno.UI.Wasm.

@agneszitte agneszitte added the project/third-party 3️⃣ Categorizes an issue or PR as relevant to 3rd party libraries label Sep 21, 2020
@MartinZikmund MartinZikmund added this to the 3.6 milestone Feb 3, 2021
@francoistanguay francoistanguay removed this from the 3.6 milestone Feb 5, 2021
@jeromelaban jeromelaban added the difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. label Feb 15, 2021
@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels May 31, 2021
@MartinZikmund MartinZikmund added this to the 3.9 milestone May 31, 2021
@MartinZikmund MartinZikmund removed this from the 3.9 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/third-party 3️⃣ Categorizes an issue or PR as relevant to 3rd party libraries
Projects
None yet
Development

No branches or pull requests

6 participants