Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests does not run against latest versions of the contracts #13498

Open
clemsos opened this issue Mar 21, 2024 · 1 comment
Open
Assignees

Comments

@clemsos
Copy link
Member

clemsos commented Mar 21, 2024

The integration tests deployment tasks in docker/development/eth-node pulls the Unlock hardhat plugin directly from npm which does not contain development versions. This was done to avoid including the test node as a workspace in the monorepo but that means integration tests arent running against dev versions.

An approach will be to copy the hardhat-plugin and contracts dist folder and add them as workspaces for the hardhat node build

@clemsos clemsos self-assigned this Mar 21, 2024
@julien51
Copy link
Member

Hum, I am not sure this is a bad thing though. The goal of integration tests is to make sure that everything works "as expected" for users "now". Since the dev contracts are not released yet, I am not sure it is bad that we test outside of them.
That said, when we're about to release the new contracts (and then before we actually trigger the upgrades) that is when the integration tests should start testing the new release.

So IMO, these tests should run against the contract's package "latest" versions. wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants