Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review packages for the whole platform and components #42

Open
amedranogil opened this issue Jun 17, 2017 · 5 comments
Open

Review packages for the whole platform and components #42

amedranogil opened this issue Jun 17, 2017 · 5 comments
Labels

Comments

@amedranogil
Copy link
Member

ensure the java packages follow a convention and that each component has it's packages defined according to that convention.
Ontologies already have this, but other EG surely do not.

@cstockloew
Copy link
Member

agreed, but what convention do you mean?

A good point to start is the javadoc:
https://universaal.github.io/platform/apidocs/index.html

It contains a list of all packages. Most of it seems to be OK. A first look reveals:

  • ucc should have package org.universAAL.tools.ucc.* instead of org.universAAL.ucc.*
  • zigbee uses org.universAAL.hw.* instead of org.universAAL.lddi.*

Do you mean this?

@amedranogil
Copy link
Member Author

amedranogil commented Jun 17, 2017

yes, but with more carefull examination:

  • ..commerce.ustore.tools move to ..tools
  • ..configurable.module should be ..middlware.module.configuration (or similar)
  • drools is inside context, reasoner
  • ..lddi.adapter (?)
  • ..managers,api vs modules (use single concention, I like the second, in the api docs list the api is at top)
  • ..mw.tracker (?)
  • all ..support may better be renamed in to better package names.
  • ..ui.handler.web (!) this one is easy.
  • ..kinect is a ui.handler
  • all junit packages should be something like ..middleware.container.junit{.bus|.mwtest} (actually this could also be a proposal to rename their respective project names and folders inside mw.core)
  • ..ioc.dependencies is an utility library
  • ..log, which module defines this package (WHY!??)

@cstockloew
Copy link
Member

all junit packages should be something like ..middleware.container.junit{.bus|.mwtest} (actually this could also be a proposal to rename their respective project names and folders inside mw.core)

I prefer to have the container (core, osgi, junit) at the end

@cstockloew
Copy link
Member

cstockloew commented Jun 19, 2017

..log, which module defines this package (WHY!??)

ri.gateway.multitenant, can you change it?

@amedranogil
Copy link
Member Author

Yes, I remember I had this discussion with @kismet the communication layer of the MTGW is all done using standard loging, that package holds the helper methods to do that; there is quite some loging; but I'll look into it.

amedranogil added a commit to universAAL/utilities that referenced this issue Jun 23, 2017
amedranogil added a commit to universAAL/security that referenced this issue Jun 23, 2017
amedranogil added a commit to universAAL/remote that referenced this issue Jun 23, 2017
cstockloew added a commit to universAAL/tools.runtime that referenced this issue Jun 23, 2017
cstockloew added a commit to universAAL/middleware that referenced this issue Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants