Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message for run.native tests.jit.only #4911

Open
kylegoetz opened this issue Apr 30, 2024 · 1 comment
Open

improve error message for run.native tests.jit.only #4911

kylegoetz opened this issue Apr 30, 2024 · 1 comment

Comments

@kylegoetz
Copy link
Contributor

The command right now (for my work implementing UDP for the JIT) currently spits out the following when testing

```ucm
    runtime-tests/selected> run.native testsruntime-tests/selected> run.native tests.jit.only
    ```
    
    
    馃洃
    
    The transcript failed due to an error in the stanza above. The error is:
    
    
      native evaluation failed
    
    
  Run `unison --codebase /Users/kylegoetz/.cache/unisonlanguage/runtime-tests.unison` to do more work with it.

Not a terribly useful error.

@kylegoetz
Copy link
Contributor Author

Though I'm not sure how it could be improved upon easily. The code that generates the error is

ExitSuccess ->
            decodeResult . deserializeNativeResponse
              =<< UnliftIO.takeMVar mv
          ExitFailure _ -> do
            UnliftIO.killThread tid
            pure . Left $ "native evaluation failed"

and ExitFailure wraps an INT only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant