Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect definition of SpacingMark used #108

Open
syvb opened this issue Sep 13, 2022 · 0 comments
Open

Incorrect definition of SpacingMark used #108

syvb opened this issue Sep 13, 2022 · 0 comments

Comments

@syvb
Copy link
Contributor

syvb commented Sep 13, 2022

UAX #29 defines SpacingMark as:

Grapheme_Cluster_Break ≠ Extend, and
General_Category = Spacing_Mark, or
any of the following (which have General_Category = Other_Letter):
U+0E33 ( ำ ) THAI CHARACTER SARA AM
U+0EB3 ( ຳ ) LAO VOWEL SIGN AM

Exceptions: The following (which have General_Category = Spacing_Mark and would otherwise be included) are specifically excluded:
[24 exception characters]

In this crate's implementation of rule GB9a, only the "General_Category = Spacing_Mark" part is checked. This crate doesn't check that Grapheme_Cluster_Break ≠ Extend or implement any of the 24 exclusions or 2 inclusions. The impact of this is very minor though, since it only affects a small set of characters, and only in extended mode.

(originally noted in #107)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant