Add FFI for day-of-year #4895
Merged
Add FFI for day-of-year #4895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
commented
May 13, 2024
| @@ -412,7 +414,17 @@ lazy_static::lazy_static! { | |||
|
|
|||
| // FFI largely deals with primitives rather than Rust's nice wrapper types | |||
| // (which are hard to do in a zero-cost way over FFI) | |||
| "icu::calendar::types", | |||
There was a problem hiding this comment.
Note: I stopped filtering out the whole icu::calendar::types module since the types inside are not homogeneous. I went through each one and allowlisted only the ones that are actually wrapper types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4891
CC @anba