Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Temporal CalendarDateDayOfYear to FFI #4891

Closed
anba opened this issue May 13, 2024 · 1 comment · Fixed by #4895
Closed

Add Temporal CalendarDateDayOfYear to FFI #4891

anba opened this issue May 13, 2024 · 1 comment · Fixed by #4895
Labels
A-ffi Area: FFI, WebAssembly, Transpilation C-calendar Component: Calendars S-small Size: One afternoon (small bug fix or enhancement) U-ecma402 User: ECMA-402 compatibility

Comments

@anba
Copy link

anba commented May 13, 2024

Implementing CalendarDateDayOfYear is easier when Date::day_of_year_info is available through the FFI.

@sffc
Copy link
Member

sffc commented May 13, 2024

Absolutely. There is a comment in allowlist.rs that says:

        // This is formatting internals, we do not expect people
        // to implement custom formatters over FFI
        "icu::calendar::Date::day_of_year_info",

but this doesn't take into consideration that this is the standard way to get the day of year in FFI. We should add that API regardless of whether we put the rest of DayOfYearInfo in FFI.

@sffc sffc added A-ffi Area: FFI, WebAssembly, Transpilation S-small Size: One afternoon (small bug fix or enhancement) C-calendar Component: Calendars U-ecma402 User: ECMA-402 compatibility labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ffi Area: FFI, WebAssembly, Transpilation C-calendar Component: Calendars S-small Size: One afternoon (small bug fix or enhancement) U-ecma402 User: ECMA-402 compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants