Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible dependence to frame of references #112

Open
mkraposhin opened this issue Dec 18, 2023 · 0 comments
Open

Possible dependence to frame of references #112

mkraposhin opened this issue Dec 18, 2023 · 0 comments

Comments

@mkraposhin
Copy link
Contributor

In file fwhFormulation.C I found next lines:

sqr(r[0])+( 1 - sqr(mag(fwh_.U0_)/fwh_.c0_))*(sqr(r[1]) + sqr(r[2]))

magrobs_[iObs][iSurf][i] = (-(mag(fwh_.U0_)/fwh_.c0_) * r[0] + R_)/(1 - sqr(mag(fwh_.U0_)/fwh_.c0_));

On these lines components of vectors r_ are used explicitly, meaning that libAcoustics is sticked to specific frame of reference. I think, that should be avoided, because we don't know in advance what frame of reference will be used by the library users.

@mkraposhin mkraposhin changed the title Possible invariance to frame of references Possible dependence to frame of references Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant