Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty NotFoundHandler does not work well with HttpContentCompressor #828

Open
yanns opened this issue Jun 8, 2022 · 0 comments
Open

Netty NotFoundHandler does not work well with HttpContentCompressor #828

yanns opened this issue Jun 8, 2022 · 0 comments

Comments

@yanns
Copy link

yanns commented Jun 8, 2022

when using HttpContentCompressor to compress the http responses, and when the handler NotFoundHandler is used, then the HttpContentCompressor does not really know how to handle this http response.
The response contains content-encoding: gzip although there is no body.
According to https://datatracker.ietf.org/doc/html/rfc7231#section-3.1.2.2, it should not do it.

When changing the io.netty.handler.codec.http.DefaultHttpResponse into a io.netty.handler.codec.http.DefaultFullHttpResponse, the issue disappears. I don't know if it's an issue on netty side.

It's a small change for unfiltered, and would help users to change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant