Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we can just add headers not set headers without dropping to underlying HttpResponse[A] #406

Open
hamnis opened this issue Feb 19, 2018 · 0 comments
Open

we can just add headers not set headers without dropping to underlying HttpResponse[A] #406

hamnis opened this issue Feb 19, 2018 · 0 comments

Comments

@hamnis
Copy link
Contributor

hamnis commented Feb 19, 2018

We should probably expose an api to set headers not just add.

See for instance: https://github.com/unfiltered/unfiltered/blob/0.10.x/filter/src/main/scala/bindings.scala#L38
@hamnis hamnis changed the title we cannot set headers without dropping to underlying HttpResponse[A] only add we can just add headrs not set headers without dropping to underlying HttpResponse[A] Feb 19, 2018
@hamnis hamnis changed the title we can just add headrs not set headers without dropping to underlying HttpResponse[A] we can just add headers not set headers without dropping to underlying HttpResponse[A] Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hamnis