Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using underlying bindings for cookie parsing #356

Open
softprops opened this issue Dec 7, 2016 · 3 comments
Open

Consider using underlying bindings for cookie parsing #356

softprops opened this issue Dec 7, 2016 · 3 comments

Comments

@softprops
Copy link
Member

We used to do this but then switched to custom parsing because we depended on am older version of the servlet spec missing some needed cookie interfaces. This is no longer the case
@softprops softprops reopened this Dec 8, 2016
@omarkilani
Copy link
Contributor

Any idea where the old code lived?

@softprops
Copy link
Member Author

The change started happening around fe61145 2011!

@softprops
Copy link
Member Author

It's mainly the cookies extractor that does the parsing. It should just rely on the bindings to do that parsing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@softprops @omarkilani