Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is *really* difficult to create an unfiltered.netty server that chunks #298

Open
thebrenthaines opened this issue Jun 24, 2015 · 2 comments

Comments

@thebrenthaines
Copy link

I respect that most people will want chunks aggregated, but it is impossible to make a scalable server that way. I have been struggling with the fact that the Server class is a case class and that the guts of its behavior are defined within it. A trait would be better.

Better yet, it could be implemented like the documentation implies, that without the .chunked() method, it doesn't aggregated. I may be missing something, but the only way I could make this work was by copying server into my own class (and copying PortBindings too, which also sucks... that should be parameterized)

@hamnis
Copy link
Contributor

hamnis commented May 1, 2017

The server should not be a case class, and be parameterized on PortBindings. Would you still be intereststed in a PR for this?

@yanns
Copy link

yanns commented Sep 7, 2017

@thebrenthaines It'd be great to share your knowledge with us.
For example, have you used a ChunkedWriteHandler instead of the default HttpObjectAggregator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants