Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataObjectManager class doesn't respect permissions of individual objects #75

Open
hdrlab opened this issue Feb 20, 2014 · 0 comments
Open

DataObjectManager class doesn't respect permissions of individual objects #75

hdrlab opened this issue Feb 20, 2014 · 0 comments

Comments

@hdrlab
Copy link
Contributor

hdrlab commented Feb 20, 2014

The DataObjectManager class will show edit & delete links for objects based on a global permission, ignoring whether any items would return false for canEdit() or canDelete(). For example, let's say that someone added fine-grained permissions to files in the assets folders. These permissions would simply be ignored.

NOTE: The underlying ComplexTableField has the same problem.
hdrlab added a commit to hdrlab/DataObjectManager that referenced this issue Feb 20, 2014
@hdrlab
Hide edit/delete links based on canEdit(), etc.
2155977 
This is a quick-n'-dirty patch to make DOM hide "action" links such as edit and delete based on per-item permissions (i.e., addresses issue unclecheese#75). While a more complete solution is needed (there are other points in the code that should be updated), it does only show the action links when those actions are allowed.
@hdrlab hdrlab mentioned this issue Feb 20, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hdrlab