Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chart.js to latest version #48

Open
bjarnef opened this issue Jan 6, 2017 · 4 comments
Open

Update Chart.js to latest version #48

bjarnef opened this issue Jan 6, 2017 · 4 comments

Comments

@bjarnef
Copy link
Collaborator

bjarnef commented Jan 6, 2017

Can we update Chart.js to latest version 2.4.0?
https://github.com/chartjs/Chart.js/releases

At the moment Analytics use version 1.0.1-beta.4
https://github.com/warrenbuckley/Analytics/blob/688a9756ef1c6eafa166dc07db81b9c60f156ae4/Analytics/App_Plugins/Analytics/lib/chartjs/Chart.js#L4

@warrenbuckley
Copy link
Member

Any specific reason @bjarnef anything missing or needed or it fixes up? Either way feel free to do a PR mate :)

@bjarnef
Copy link
Collaborator Author

bjarnef commented Jan 6, 2017

@warrenbuckley it has some cool new features like Mixed chart types, New chart axis types and animations when there is change in dataset.
http://www.chartjs.org/

Furthermore the current version was a beta, so it seems there a lot of bugfixes, enhancements and new features 👍
https://github.com/chartjs/Chart.js/releases

@bjarnef
Copy link
Collaborator Author

bjarnef commented Jan 8, 2017

I need to adjust it a bit more for version 2.4.0
@warrenbuckley maybe create a milestone for Analytics version 1.3.0?
image

@warrenbuckley
Copy link
Member

OK well free to do a PR then please. I unfortunately don't have as much time as I once used to :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants