-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.1.0-beta? release #123
Comments
Yeah, sounds good to me. Better safe than sorry. |
If you have a few minutes could you have a glance at #122 I also think it makes sense to beta release as both of these features are loosely linked to the same features being added to the ImageProcessor CloudImageService for most usage. (I need to complete the TLS config PR for that too) |
I agree, hopefully I have some time next weekend for testing. I refer to @Jeavon's initial question;-) |
@JimBobSquarePants cool! Perfect that I add the TLS config option to the AzureImageService then too. |
@Jeavon hope my latest merge for sas parsing did not come to late for the 1.1.0-beta... |
@idseefeld no rush, I'm not ready with TLS feature either |
@Jeavon I had to change the SAS token change again :-( |
@idseefeld is the SAS token feature stable yet or still WIP? |
Is this beta going to be released soon? Im having issues with turning off TLS 1.0 and 1.1 and the stack trace is referring to this plugin. I hope this will resolve that |
Hi Jeavon,should be stable and all test are running without failures. I'll add some documentation when it is released.
Dirk
|
@Jeavon & @JimBobSquarePants |
Could you not simply point the user to the relevant MS Docs? We shouldn't have to keep up every time Azure move their cheese. |
Would proposed beta release address issue of allowing form uploads to be stored in separate secure container (not 'media') as discussed in #98. Or would one need to merge latest changes from current branch with fork if separate container support and latest fixes required? Just looking for guidance, thanks. |
@gavinfaux No, and I don't think it the workaround should be added either. This is an issue form the Forms project and pressure should be put on Umbraco to fix their issues. |
@idseefeld could you please create a PR using the develop branch as source and master as the target? This will allow myself and @JimBobSquarePants the opportunity to review all the changes you've made. Please don't accept this PR until it's been reviewed by us. |
@JimBobSquarePants agree regarding fix via Umbraco Forms; we don't mind building from latest source with workaround on this occasion; Umbraco Cloud support kind of suggest coming here and no feedback available for Forms regarding pending releases with required functionality as yet. |
Hi @Jeavon @JimBobSquarePants, |
v1.1.0 has been released |
@JimBobSquarePants @idseefeld as we potentially have 2 new features in SAS token support and TLS configuration I'm thinking we should create a v1.1.0-beta release to get these new features some testing.
What do you think?
The text was updated successfully, but these errors were encountered: