Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.0-beta? release #123

Closed
Jeavon opened this issue Oct 3, 2018 · 19 comments
Closed

v1.1.0-beta? release #123

Jeavon opened this issue Oct 3, 2018 · 19 comments

Comments

@Jeavon
Copy link
Collaborator

Jeavon commented Oct 3, 2018

@JimBobSquarePants @idseefeld as we potentially have 2 new features in SAS token support and TLS configuration I'm thinking we should create a v1.1.0-beta release to get these new features some testing.

What do you think?

@JimBobSquarePants
Copy link
Contributor

Yeah, sounds good to me. Better safe than sorry.

@Jeavon
Copy link
Collaborator Author

Jeavon commented Oct 3, 2018

If you have a few minutes could you have a glance at #122

I also think it makes sense to beta release as both of these features are loosely linked to the same features being added to the ImageProcessor CloudImageService for most usage. (I need to complete the TLS config PR for that too)

@idseefeld
Copy link
Contributor

idseefeld commented Oct 3, 2018

I agree, hopefully I have some time next weekend for testing. I refer to @Jeavon's initial question;-)

@JimBobSquarePants
Copy link
Contributor

@Jeavon The CloudImageService is on it's way out. I'm replacing it with a dedicated AzureImageService.

https://github.com/JimBobSquarePants/ImageProcessor/blob/6bcfc369461c194c2c534405e9c54f4aa75bf8e7/src/ImageProcessor.Web.Plugins.AzureBlobCache/AzureImageService.cs

I don't need SAS token support for that because if the blob is private we simply stream it to the response.

Have had a look at #122 Can't see anything amiss, just a couple of questions.

@Jeavon
Copy link
Collaborator Author

Jeavon commented Oct 3, 2018

@JimBobSquarePants cool! Perfect that I add the TLS config option to the AzureImageService then too.

@idseefeld
Copy link
Contributor

@Jeavon hope my latest merge for sas parsing did not come to late for the 1.1.0-beta...

@Jeavon
Copy link
Collaborator Author

Jeavon commented Oct 3, 2018

@idseefeld no rush, I'm not ready with TLS feature either

@idseefeld
Copy link
Contributor

@Jeavon I had to change the SAS token change again :-(

@Jeavon
Copy link
Collaborator Author

Jeavon commented Oct 24, 2018

@idseefeld is the SAS token feature stable yet or still WIP?

@tonygayter
Copy link

Is this beta going to be released soon? Im having issues with turning off TLS 1.0 and 1.1 and the stack trace is referring to this plugin. I hope this will resolve that

@idseefeld
Copy link
Contributor

idseefeld commented Oct 24, 2018 via email

@idseefeld
Copy link
Contributor

idseefeld commented Oct 24, 2018

@Jeavon & @JimBobSquarePants
I have created a wiki page about the SAS details in my fork. Because this is quite specific, a wiki page seems to be a better place. Perhapse we can put a note in the README.md?
Looks like you cannot create pull requests for wikis :(
But you may have a look https://github.com/idseefeld/UmbracoFileSystemProviders.Azure/wiki
When you agree I'll copy the wiki over to this repo.

@JimBobSquarePants
Copy link
Contributor

Could you not simply point the user to the relevant MS Docs? We shouldn't have to keep up every time Azure move their cheese.

@gavinfaux
Copy link

Would proposed beta release address issue of allowing form uploads to be stored in separate secure container (not 'media') as discussed in #98.

Or would one need to merge latest changes from current branch with fork if separate container support and latest fixes required? Just looking for guidance, thanks.

@JimBobSquarePants
Copy link
Contributor

@gavinfaux No, and I don't think it the workaround should be added either. This is an issue form the Forms project and pressure should be put on Umbraco to fix their issues.

@Jeavon
Copy link
Collaborator Author

Jeavon commented Oct 30, 2018

@idseefeld could you please create a PR using the develop branch as source and master as the target? This will allow myself and @JimBobSquarePants the opportunity to review all the changes you've made. Please don't accept this PR until it's been reviewed by us.

@gavinfaux
Copy link

@JimBobSquarePants agree regarding fix via Umbraco Forms; we don't mind building from latest source with workaround on this occasion; Umbraco Cloud support kind of suggest coming here and no feedback available for Forms regarding pending releases with required functionality as yet.

@joelblake1
Copy link

Hi @Jeavon @JimBobSquarePants,
Is there any ETA on the beta release yet? I've tried the version in develop with SAS and it works great! 👍
@idseefeld Great work on the wiki page as well. Very easy to follow.

@Jeavon
Copy link
Collaborator Author

Jeavon commented Feb 18, 2020

v1.1.0 has been released

@Jeavon Jeavon closed this as completed Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants