Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert reducer using ngrx/entity ? #16

Open
rijine opened this issue Feb 1, 2018 · 3 comments
Open

convert reducer using ngrx/entity ? #16

rijine opened this issue Feb 1, 2018 · 3 comments

Comments

@rijine
Copy link

rijine commented Feb 1, 2018

No description provided.

@gssjr
Copy link

gssjr commented Feb 2, 2018

I was wondering about this too:

https://github.com/ngrx/platform/tree/master/docs/entity

@tunecino
Copy link

tunecino commented Feb 3, 2018

I don't think it is a good idea. I've seen another tutorial before this one using it from start and it was confusing for me, ngrx/entity is a helper module that was introduced later to help reduce code boilerplates. I like it very much and I'm using it with most of my entities now but I also liked the fact that it wasn't used in this tutorial so I was able to better understand how ngrx/redux works. I think using helpers designed to reduce/hide parts of code should be avoided at earlier learning steps.

@rijine
Copy link
Author

rijine commented Feb 3, 2018

@tunecino agree...in future you might be using entity also. so at least enhancing this with entity will be another good step. May be to different branch!

@rijine rijine changed the title covert reducer using ngrx/entity ? convert reducer using ngrx/entity ? Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants