Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/customize tooltip for operators. #261

Closed
kari-d opened this issue Aug 6, 2020 · 8 comments
Closed

Add/customize tooltip for operators. #261

kari-d opened this issue Aug 6, 2020 · 8 comments

Comments

@kari-d
Copy link

kari-d commented Aug 6, 2020

For eg. '==' tooltip as "Equals", 'Like' tooltip as "Contains", etc

@bhargavkumar7031
Copy link
Contributor

Hi, Can i work on this issue?

@ukrbublik
Copy link
Owner

@bhargavkumar7031 Sure

@bhargavkumar7031
Copy link
Contributor

Hi @ukrbublik,

Looks like tooltip is added only in MUI and antD. Should tooltip for operator be applied to only these?

@ukrbublik
Copy link
Owner

I think yes.
Other supported UI frameworks (Fluent, Bootstrap) have fewer features, so the main focus should be on MUI and AntD.

@bhargavkumar7031
Copy link
Contributor

Raised PR. ci/codesandbox failed. Please let me know if there are any channels for communication

@ukrbublik
Copy link
Owner

Error from ci/codesandbox is not related to your changes:

 ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE  Cannot perform a frozen installation because the version of the lockfile is incompatible with this version of pnpm

Try either:
1. Aligning the version of pnpm that generated the lockfile with the version that installs from it, or
2. Migrating the lockfile so that it is compatible with the newer version of pnpm, or
3. Using "pnpm install --no-frozen-lockfile".
Note that in CI environments, this setting is enabled by default.
Error: Process rejected with status code 1
    at ChildProcess.<anonymous> (/app/dist/utils/exec.js:20:27)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess._handle.onexit (node:internal/child_process:292:12) {
  code: 1

You can ping me on discord: ukrbublik

@bhargavkumar7031
Copy link
Contributor

Any update here?

@ukrbublik
Copy link
Owner

@bhargavkumar7031
Sorry for a long process with your PR.
I've merged your commit to master : 0d5e94a
However, then I changed the implementation details of tooltips for operators.
Instead of displaying operator key as tooltip, you can add new special tooltip property in operator config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants