Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter sees joined and modified emoji as multiple #172

Open
r-tae opened this issue Oct 23, 2023 · 1 comment
Open

Interpreter sees joined and modified emoji as multiple #172

r-tae opened this issue Oct 23, 2023 · 1 comment

Comments

@r-tae
Copy link

r-tae commented Oct 23, 2023

(Found while testing #167, but I figured it wasn't specifically pad related)

All of these look like single emoji but break as if they were multiple:

heart, VS16 (this is the regular emoji heart and imo this should definitely work, even if the rest aren't important)
person, ZWJ 🧑‍❤‍🧑
person, skin tone, ZWJ 🧑🏿‍❤‍🧑🏻
person, skin tone 👦🏾

Also this works perfectly fine:

binding to the ZWJ

@r-tae r-tae changed the title Parser sees joined and modified emoji as multiple Interpreter sees joined and modified emoji as multiple Oct 23, 2023
@kaikalii
Copy link
Member

I've made a preliminary fix for this in 540ac08.
Each grapheme will be considered a single character.
I still have some work to do making spans correct, but all your example seem to parse correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants