Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of 1.0 #165

Open
3 tasks
matze opened this issue Jul 28, 2018 · 9 comments
Open
3 tasks

Release of 1.0 #165

matze opened this issue Jul 28, 2018 · 9 comments

Comments

@matze
Copy link
Contributor

matze commented Jul 28, 2018

This is a meta issue discussing things necessary for the release of version 1.0 that does not allow any API removal or backwards-incompatible change. Of course all tickets marked with a milestone 1.0 should be fixed but there are a few things worth discussing:

  • Should we drop CMake with 1.0 or later?
  • Which issues really block release of 1.0, i.e. which require API changes and …
  • … which issues could we postpone because they do not affect API stability?
@tfarago
Copy link
Contributor

tfarago commented Jul 30, 2018

Oh wow! This is big. Regarding the fist point, if we keep CMake does it mean that we have to keep it forever? It's not an API-related thing, so I don't know how strict the rules are here.

@matze
Copy link
Contributor Author

matze commented Jul 30, 2018

Regarding the fist point, if we keep CMake does it mean that we have to keep it forever? It's not an API-related thing, so I don't know how strict the rules are here.

No, that's just infrastructure. We can drop it any time but it would be good time instead of keeping it around forever. Although we should really check if someone is not able to use meson/ninja.

@tfarago
Copy link
Contributor

tfarago commented Jul 31, 2018

@Milkdrop and @lucito, have you tried that build system already? If not, can you please?

@sgasilov
Copy link

sgasilov commented Aug 1, 2018

Hi,
1.0 does not work for me. The simplest flatcorrect: tofu flatcorrect --projections tomo --output /data/sergei/testtest/proj/proj-%04i.tif --darks darks --flats flats produces some meaningless salt-and-pepper like image. Please tell me output of which command would you need for troubleshooting.
ufo-core-1-0-problems

@matze
Copy link
Contributor Author

matze commented Aug 1, 2018

Wait a second, what means 1.0 for you? Tomas was just asking if compiling via meson build instead of cmake .. would make a difference to you?

@sgasilov
Copy link

sgasilov commented Aug 1, 2018

Ahhh, I see.. Well, I have removed old ufo-core and installed this release using cmake. And it does not work. So I rolled back to April release and it works as it should again. Do I have to reinstall all dependents each time I update core?

I had no clue about existence of that meson system, but I will give it a try of course.

Cheers,
Sergei.

@matze
Copy link
Contributor Author

matze commented Aug 2, 2018

Please tell me output of which command would you need for troubleshooting.

That line should be enough, can you replicate the issue @tfarago?

@tfarago
Copy link
Contributor

tfarago commented Aug 3, 2018

Hi, which versions of core and filters do you use @Milkdrop exactly? Please type git log in the ufo-core and ufo-filters directories and let us know what the last commit is.
As for me, I am happily flatcorrecting away with 9ac9a03

@sgasilov
Copy link

sgasilov commented Aug 3, 2018

Hola, let me try to update all modules to the latest versions, I'm pretty sure the problem will disappear.

MarcusZuber pushed a commit that referenced this issue May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants