[Bug]: NodePos depth is not set correctly

[furkan3ayraktar]

Which packages did you experience the bug in?

core

What Tiptap version are you using?

2.3.1

What’s the bug you are facing?

The depth of the NodePos is not set correctly. You can see it in the below snippet:

tiptap/packages/core/src/NodePos.ts

Lines 133 to 155 in 2b24986

	get children(): NodePos[] {
	const children: NodePos[] = []
	this.node.content.forEach((node, offset) => {
	const isBlock = node.isBlock && !node.isTextblock
	const targetPos = this.pos + offset + 1
	const $pos = this.resolvedPos.doc.resolve(targetPos)
	if (!isBlock && $pos.depth <= this.depth) {
	return
	}
	const childNodePos = new NodePos($pos, this.editor, isBlock, isBlock ? node : null)
	if (isBlock) {
	childNodePos.actualDepth = this.depth + 1
	}
	children.push(new NodePos($pos, this.editor, isBlock, isBlock ? node : null))
	})
	return children

In line 149, the actualDepth of the childNodePos is set correctly. However, in line 152, the childNodePos is not pushed to the children array. Instead, a brand new NodePos instance is created. As a result, the actualDepth is never set.

Simply, replacing line 152 with children.push(childNodePos) will solve the issue.

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

The depth of the NodePos is set correctly.

Anything to add? (optional)

No response

Did you update your dependencies?

• Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

• Yes, I’m a sponsor. 💖