Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRO]: Text selection across multiple nodes causes comment mark to overextend. #5075

Open
2 tasks done
EricHasegawa opened this issue Apr 17, 2024 · 0 comments
Open
2 tasks done
Labels
Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@EricHasegawa
Copy link
Contributor

Which packages did you experience the bug in?

comments

What Tiptap version are you using?

"@tiptap-pro/extension-comments": "^2.8.1",

What’s the bug you are facing?

Creating a comment with a text selection across multiple nodes applies the comments to both nodes fully, rather than just the selected text.

Steps to reproduce:

  1. Select text between multiple nodes (2 paragraphs, for example)
  2. Create a comment using setThread on those nodes.
  3. See that the mark is applied to both nodes and extends beyond the selected text.

This is reproducible in the comments demo on your website here.

What browser are you using?

Chrome

Code example

https://tiptap.dev/docs/editor/comments/overview

What did you expect to happen?

Comment mark applies only to the selected text.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@EricHasegawa EricHasegawa added Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Triage open
Development

No branches or pull requests

1 participant