Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Blockquote shortcut does not work when using starter-kit #4994

Open
1 of 2 tasks
Mathias-S opened this issue Mar 20, 2024 · 0 comments · May be fixed by #4995
Open
1 of 2 tasks

[Bug]: Blockquote shortcut does not work when using starter-kit #4994

Mathias-S opened this issue Mar 20, 2024 · 0 comments · May be fixed by #4995
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@Mathias-S
Copy link

Which packages did you experience the bug in?

starter-kit

What Tiptap version are you using?

2.2.4

What’s the bug you are facing?

When using the starter-kit, using keyboard shortcut for Blockquote (Control Shift B / Cmd Shift B) instead triggers the Bold command (Control B / Cmd B). This is reproducible in the official TipTap Default text editor example.

What browser are you using?

Chrome

Code example

https://tiptap.dev/docs/editor/examples/default

What did you expect to happen?

The Blockquote shortcut (Control Shift B / Cmd Shift B) should fire the toggleBlockquote command, and not the toggleBold command, when using the starter-kit.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Mathias-S Mathias-S added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Mar 20, 2024
Mathias-S added a commit to Mathias-S/tiptap that referenced this issue Mar 20, 2024
@Mathias-S
fix: make blockquote shortcut work in starter-kit
59c3ca1 
Because blockquote uses Mod-Shift-b, and bold uses Mod-b,
the bold shortcut will override the blockquote shortcut if added
to the extensions later.

Fixes ueberdosis#4994
@Mathias-S Mathias-S linked a pull request Mar 20, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
Tiptap
Status: Triage open
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make blockquote shortcut work in starter-kit Mathias-S/tiptap
1 participant
@Mathias-S