Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer overflow in Java wrapper #1452

Open
scheidtp opened this issue Jan 5, 2023 · 0 comments
Open

Integer overflow in Java wrapper #1452

scheidtp opened this issue Jan 5, 2023 · 0 comments

Comments

@scheidtp
Copy link

scheidtp commented Jan 5, 2023

if (compressedStream== null || (compressedStream.length != width*height*depth/8)) {
logMessage("OpenJPEGJavaEncoder.encodeImageToJ2K: (re-)allocating " + (width*height*depth/8) + " bytes for the compressedStream");
compressedStream = new byte[width*height*depth/8];
}

The current implementation of calculating the destination byte array size is buggy.
My test image has a size of 28000x7000x16. Because the calculation processes the operants from left to right, after multiplying the depth the calculated value creates an int overflow, which results in a negative destination array size. Simple brackets around the division of the depth by 8 should resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant