Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Animated checkmark #181

Closed
EDWIN1669086 opened this issue Nov 8, 2023 · 0 comments 路 Fixed by #251 路 May be fixed by #278
Closed

馃殌 Feature: Animated checkmark #181

EDWIN1669086 opened this issue Nov 8, 2023 · 0 comments 路 Fixed by #251 路 May be fixed by #278
Assignees
Labels
enhancement New feature or request

Comments

@EDWIN1669086
Copy link
Collaborator

EDWIN1669086 commented Nov 8, 2023

Context

Right now we are using a dependency to draw a static checkmark on all our pages.

Problem

Having unnecessary dependencies, for one, makes our code slower, but also it does not have an interesting animation feedback when the user gets the answer correct.

Proposed Solution

I would advise to use an existing checkmark SVG found online or through one of these solutions, but for learning purposes, I would definitely understand how the CSS interacts with the SVG (ie. what class corresponds to what and what each CSS property does). You could also look into SVG animations for fun as well before/after this issue.

Example Solution
Example Solution

This is a 馃殌 Feature Request

@EDWIN1669086 EDWIN1669086 added the enhancement New feature or request label Nov 21, 2023
EDWIN1669086 pushed a commit that referenced this issue Feb 6, 2024
* Add animated checkmark to FinishCode and KhanCard

* moved checkmark stylings to Checkmark.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants