Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GraphQL null field workaround #260

Open
khxia opened this issue Oct 22, 2021 · 2 comments
Open

Remove GraphQL null field workaround #260

khxia opened this issue Oct 22, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@khxia
Copy link
Contributor

khxia commented Oct 22, 2021

Before, when no events had the conferenceLink attribute, the GraphQL will not detect it when all of the events have that property as null. The workaround to this that we found was to set conferenceLink = ''; (look for it in the gatsby-node.js file). However, it seems that Gatsby has addressed this issue using a new schema customization API. So we need to use that instead.

This is the issue:
gatsbyjs/gatsby#6800

@khxia khxia added the bug Something isn't working label Oct 22, 2021
@khxia
Copy link
Contributor Author

khxia commented Jan 7, 2022

Instead of using createSchemaCustomization, we could try directly adding it into Gatsby sourceNodes.
This will still allow us to use the createTypes function.

https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/#createSchemaCustomization

https://www.gatsbyjs.com/docs/reference/graphql-data-layer/schema-customization/#creating-type-definitions

https://www.gatsbyjs.com/docs/reference/config-files/actions/#createTypes

This stuff could be wrong, but I came across it and wanted to make a note of this.

@khxia
Copy link
Contributor Author

khxia commented Jan 7, 2022

This issue is now also prevalent for link attribute in highlights.js

@EinarBalan EinarBalan removed their assignment Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants