Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXD-340 ⁃ form submission not handling numbers properly #240

Open
frickjack opened this issue Mar 6, 2018 · 1 comment
Open

PXD-340 ⁃ form submission not handling numbers properly #240

frickjack opened this issue Mar 6, 2018 · 1 comment
Labels

Comments

@frickjack
Copy link
Contributor

frickjack commented Mar 6, 2018

From @cgmeyer

minor problem with using the form though:
when you enter an integer for, e.g., 4 for “number_of_melanomas_in_family”. when you click “upload submission json from form” it puts quotes around it (edited)
and then says it’s not an integer :

See also uc-cdis/sheepdog#95 - if we patch sheepdog, then we can close this ...

@frickjack frickjack added the bug label Mar 6, 2018
@cgmeyer
Copy link

cgmeyer commented Mar 7, 2018

Form submission also adds quotes to booleans (true -> "true") which leads to the error:
"message": "'true' is not of type 'boolean'",
"type": "INVALID_VALUE"

@philloooo philloooo changed the title form submission not handling numbers properly PXD-340 ⁃ form submission not handling numbers properly May 30, 2018
@philloooo philloooo added the bug label May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants