Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastboot:flashing_unlock does not handle code_url #183

Open
amartinz opened this issue Mar 26, 2022 · 3 comments
Open

fastboot:flashing_unlock does not handle code_url #183

amartinz opened this issue Mar 26, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@amartinz
Copy link
Member

fastboot:oem_unlock: allows providing a code_url to specify a link to follow for instructions regarding how to obtain a code to unlock the bootloader.

fastboot:flashing_unlock: does the same as fastboot:oem_unlock: but does not allow providing a code_url according to action.schema.yml.

@NeoTheThird
Copy link
Member

Is it even possible to supply a code to it? Maybe we simply haven't had a device that used flashing unlock and needed a code yet.

@NeoTheThird NeoTheThird added the enhancement New feature or request label Mar 26, 2022
@amartinz
Copy link
Member Author

I wanted to abuse that feature to show a link with instructions of how to unlock the bootloader.

so maybe should be renamed to link to match existing actions allowing to open an url?

@NeoTheThird
Copy link
Member

That would be useful. But cave: That is not all that code_url does for fastboot:oem_unlock. It actually expects the user to obtain and enter a code. On devices that do not need that code, it would not work. So we should implement an instructions link for both of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants