nonsdk_container_setup: correct sources line changing #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New version of Ubuntu LXD images seem to have a slightly different sources line. Account for those by making the trailing slash optional. Fixes: #71
|
Upon some further investigation, this PR seems to generate a ports.list file that makes sense, but does not fix the fact that |
|
Could you please share the content of your |
|
|
Sorry for the delay. Could you please test the new version? It's weird, because the code seems to work with this content, but it seems like it's overwritten after the fact. My guess is that it's cloud-init, so I also inject our changes into cloud-init's template. Let's see if it works. |
|
Sorry for the (even longer) delay! Got very busy with school and other projects. Still doesn't work for some reason. I have not been able to figure out exactly why it doesn't work either; seems very, very weird. The sources list file: The ports.list file: |
peat-psuwit
force-pushed
the
correct-source-setup
branch
from
eb3126b
to
8ac3b4e
Compare
|
Ok. What happens is the cloud-init template has changed its location, so the anti-race code doesn't work. I've pushed new version. Please try again. (Note: this PR doesn't include changes for Noble yet) |
|
With this PR (and also PR 79, which I dont think should have changed anything for this, but mentioning incase it is relevant), I can now build things like |
Seems like cloud-init can update sources.list after us. Make sure it will include our changes by injecting our changes into cloud-init too.
peat-psuwit
force-pushed
the
correct-source-setup
branch
from
8ac3b4e
to
a7e876e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of Ubuntu LXD images seem to have a slightly different sources line. Account for those by making the trailing slash optional.
Fixes: #71