Skip to content
This repository has been archived by the owner on May 4, 2021. It is now read-only.

--log-fmt=console could be more human readable #286

Open
rgeary1 opened this issue Oct 25, 2019 · 0 comments
Open

--log-fmt=console could be more human readable #286

rgeary1 opened this issue Oct 25, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@rgeary1
Copy link

rgeary1 commented Oct 25, 2019

Makisu offers two logging formats, --log-fmt=json and --log-fmt=console. Many users would be used to a "docker build" command line experience, but neither log-fmt offers the same type of human-readable output. The "console" format is more human-readable than json, but it could be improved.

Observations

  1. Unusually, the timestamp for --log-fmt=console is reported in nanos-since-epoch in an exponential format, e.g. 1.571969064344166e+09
  2. Printing the log level (info / error) is only useful when grepping for errors, but often error is not an error, but when the RUN command prints to stderr
  3. When RUN commands output a trailing newline, console logger prints it and still adds its own

Suggestions

  1. An improvement would be to make the timestamp an RFC-3339 or ISO-8601 format, or print ISO-8601 at the start and later log lines print {seconds.micros} since makisu start
  2. Docker omits printing "info" when printing standard messages, and stderr is printed in red. This gives a human readable output.
  3. Trim trailing newlines when echoing to the terminal as console logger prints its own newline
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants