Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tasks produce errors if Growl/Snarl/notify-send is not installed #328

Open
bjagg opened this issue May 23, 2019 · 1 comment
Open

Comments

@bjagg
Copy link
Member

bjagg commented May 23, 2019

Describe the bug
Building on a computer with OSX/Windows/Ubuntu triggers errors if Growl/Snarl/notify-send is not installed for the Gradle build-announcements plugin to use.

To Reproduce
Steps to reproduce the behavior:

  1. Run ./gradlew clean portalInit on a computer without the above software

Expected behavior
No errors from build-announcements when above software is not installed

Platform:

  • uPortal Version: uPortal 5
  • OS: Windows 10, MacOS, Ubuntu

Additional context
Consider using gradle.properties and conditional plugin loading with a default of disabled to address this issue.
See:
https://docs.gradle.org/current/userguide/announce_plugin.html#announce_plugin
https://stackoverflow.com/questions/36039793/android-gradle-conditionally-apply-plugin-based-on-build-type

@bjagg
Copy link
Member Author

bjagg commented May 23, 2019

This should also be addressed if present in uPortal, Notifications Portlet, and any other Gradle project.

N.B. This plugin is deprecated, so the simple solution is to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant