Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closeOnBackpressure should block all further sending #1338

Open
ghost opened this issue Sep 20, 2021 · 0 comments
Open

closeOnBackpressure should block all further sending #1338

ghost opened this issue Sep 20, 2021 · 0 comments

Comments

@ghost
Copy link

ghost commented Sep 20, 2021

When we reach maxBackpressure we start closing the connection (which doesn't even work on Windows!). But there is no guarantee that backpressure won't drain a bit and we then send another message still. This can cause a gap in the stream. This needs to be guaranteed that when we reach maxBackpressure and we are closing, never send anything more. To guarantee stream integrity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant