Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart with quoted boundary is not parsed correctly, which is not standard compliant. #1248

Open
fragrans opened this issue Apr 28, 2021 · 3 comments
Labels

Comments

@fragrans
Copy link

I was using Powershell scripts to run some tests with my app embedded with uWebsockets, and found wired errors;
I googled around, found this: PowerShell/PowerShell#9241

@ghost ghost added the bug label May 6, 2021
@ghost
Copy link

ghost commented May 6, 2021

MultipartParser does not work with " like you say. This is not an issue in most cases but apparently Microsoft's tools rely on this.

@fragrans
Copy link
Author

fragrans commented May 6, 2021

I had to remove quotes inside MultipartParser.prependedBoundary directly after construct;

@ghost
Copy link

ghost commented May 6, 2021

Really the WebSocketExtensions parsing and MultipartParser and HttpParser should be refactored to share the same parsings for things like XX="YY"; ZZ="ÅÅ" kind of parsing that is used in web protocols.

@ghost ghost added the v19 label May 6, 2021
@uNetworkingAB uNetworkingAB changed the title Post method with quoted boundary is not parsed correctly, which is not standard compliant. Multipart with quoted boundary is not parsed correctly, which is not standard compliant. Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants