-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid query does not return error, but spins forever #667
Comments
For example, typing in wizard IMHO, the error (at least a generic catch-all) should be returned to the user and operation aborted instead.
|
Overpass Turbo tries to load this file: https://overpass-turbo.eu/assets/en-US-a78e4a15.js const e={"en-US":{}};export{e as default}; When trying to build a query in the wizard for the first time this exception is logged:
When hitting the build query button a second time, the exception mentioned by @mnalis above is logged. To me it seems there are two problems:
|
The preset translation files come from https://github.com/openstreetmap/id-tagging-schema/tree/main/dist/translations To me it seems that the language-country variants are meant to be merged with the language-without-country.files. E.g. en.json contains the English presets. en-AU.json seems to contain only the terms that differ from en.json. en-US.json is empty. I think when the requested language is en-AU, one would need to load en.json, then load en-AU.json and merge it. Entries from en-AU should overwrite entries from en. What should happen if a user requests a language without translated presets, such as |
Would just putting that language loading block in It is really making wizard quite annoying to use (i.e. I've by now had to train myself to never click on |
When entering the query at wizard at http://overpass-turbo.eu/ which is not recognized, previously error was returned.
Now, it seems that it simply runs "running line" spinner forever, even when just
build query
is pressed (initially I was pressingbuild and run query
and wondering why my seemingly simple/small query is taking so long to complete)From example, entering in wizard
"bicycle:repair" in Croatia
and clickingbuild query
just runs the spinner (I've waited for several minutes and given up so I do not know if it timeouts eventually):Modifying that query to
"bicycle:repair"=* in Croatia
returns correctly in about a second forbuild and run query
(and immediately for justbuild query
)Started happening in last few weeks (I guess in or about the same major update which also broke "save/load from OSM" functionality from #665)
Possibly related issue: #657 (comment)
The text was updated successfully, but these errors were encountered: