Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On MacOS cmd + H is hijacking default OS behaviour. #656

Open
platlas opened this issue Sep 16, 2023 · 1 comment
Open

On MacOS cmd + H is hijacking default OS behaviour. #656

platlas opened this issue Sep 16, 2023 · 1 comment

Comments

@platlas
Copy link

platlas commented Sep 16, 2023

Problem:
on MacOS cmd + H is system-wide shortcut for hiding focused window. While using overpass-turbo in Firefox[1] this shortcut opens site's help popup instead of hiding window.

It is happening probably because of this line of code:

(event.ctrlKey || event.metaKey) &&

event.metaKey represents ⌘ Command key on MacOS. In case of Mac it is not necessary to use cmd here since Mac do have ctrl key as well - so help dialog can be still opened with ctrl + H.
However I'm not sure how removing event.metaKey from this condition would influence other operating systems.

[1]: This does not occur in Safari browser since Safari prevents use of default shorcuts by website.

@brunnerpaul
Copy link

Same issue here, reproduced on MacOS with Brave, Firefox, Chrome.
Would be a great to resolve this conflict with the "hide browser window" shortcut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants